Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lucas part2 #7

Closed
wants to merge 6 commits into from
Closed

Lucas part2 #7

wants to merge 6 commits into from

Conversation

LuHG18
Copy link

@LuHG18 LuHG18 commented Nov 8, 2023

Part 2 Fix

Github Issue Number Here: <YOUR_GITHUB_ISSUE_NUMBER_HERE (include the hashtag)>
What user problem are we solving?

What solution does this PR provide?

Testing Methodology
How did you test your changes and verify that existing
functionality is not broken

Any other considerations

@LuHG18 LuHG18 requested a review from a team as a code owner November 8, 2023 00:44
Copy link

sweep-ai bot commented Nov 8, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.

Copy link

sonarcloud bot commented Nov 8, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
2.7% 2.7% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@LuHG18
Copy link
Author

LuHG18 commented Nov 8, 2023

@karkir0003
Copy link
Member

@LuHG18 looks good to me. Thank you for this PR. Looking forward to your part 3 PR in the beginner project. I'll mark your PR as closed since we will not actually merge these changes into the real DLP app

@karkir0003 karkir0003 closed this Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants